Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lint via lint_defs instead of lints #110396

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

Noratrieb
Copy link
Member

This gets rid of a blocking dependency edge from rustc_lint->rustc_analysis->rustc_hir_typeck->rustc_interface

image

This gets rid of a blocking dependency edge from
`rustc_lint->rustc_analysis->rustc_hir_typeck->rustc_interface`
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@Noratrieb Noratrieb changed the title Use lints via lint_defs instead of lints Use lint via lint_defs instead of lints Apr 16, 2023
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@jyn514
Copy link
Member

jyn514 commented Apr 16, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 16, 2023

📌 Commit ee8f92b has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2023
…fee1-dead

Rollup of 3 pull requests

Successful merges:

 - rust-lang#109665 (Remove `remap_env_constness` in queries)
 - rust-lang#110345 (Remove `TypeSuper{Foldable,Visitable}` impls for `Region`.)
 - rust-lang#110396 (Use lint via `lint_defs` instead of `lints`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Apr 16, 2023
Use lint via `lint_defs` instead of `lints`

This gets rid of a blocking dependency edge from `rustc_lint->rustc_analysis->rustc_hir_typeck->rustc_interface`

![image](https://user-images.githubusercontent.com/48135649/232291152-fc61e6c5-9b1e-4db1-8101-dfaa3b7d30c6.png)
@bors bors merged commit 7fb14ae into rust-lang:master Apr 16, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 16, 2023
@Noratrieb Noratrieb deleted the speedy-bootstrap branch April 16, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants